Drop vendored copy of LooseVersion #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
deprecated/LooseVersion
branch
from
49cc58f
to
bb21ae1
Compare
tremble
force-pushed
the
deprecated/LooseVersion
branch
2 times, most recently
from
f6798d3
to
8cff71d
Compare
tremble
force-pushed
the
deprecated/LooseVersion
branch
from
8cff71d
to
cc89d99
Compare
ansibullbot
added
community_review
feature
|
recheck |
alinabuzachis
approved these changes
Jul 19, 2023
|
recheck |
|
@tremble this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
tremble
force-pushed
the
deprecated/LooseVersion
branch
from
63b470e
to
8df9291
Compare
ansibullbot
added
community_review
and removed
merge_commit
|
@jillr can we manually merge this? The tests are just being flaky and being a dependency of AnsibleAWSModule it's triggering all the tests |
jillr
approved these changes
Jul 25, 2023
alinabuzachis
pushed a commit
to taehopark32/amazon.aws
that referenced
this pull request
Jul 31, 2023
krisek
pushed a commit
to krisek/amazon.aws
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
distutils was deprecated and is planned to be removed in Python 3.12 (later this year). In preparation we vendored a copy of distutils.version (#599). Drop this vendored copy and move from distutils.version.LooseVersion to packaging.version.Version.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION
While packaging is not part of the base Python install, it is required by Ansible Core already.